Add upload to IPFS on teams & account avatar form fields #4807

MananTank · 2024-09-25T22:22:11Z

Problem solved

Short description of the bug fixed or feature added

PR-Codex overview

This PR focuses on enhancing the account and team settings pages by implementing image upload functionalities for user and team avatars, updating component structures, and ensuring better state management in the UI.

Detailed summary

Added updateAccountImage and updateTeamImage functions to handle image uploads.
Changed AccountSettingsPageUI and TeamGeneralSettingsPageUI to receive image update props.
Updated layout classes from min-h-full to min-h-screen.
Refactored GeneralSettingsPage to TeamGeneralSettingsPage.
Added token validation in account and team settings pages.
Introduced placeholder logic for uploading images to IPFS.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

changeset-bot · 2024-09-25T22:22:14Z

⚠️ No Changeset found

Latest commit: 88db5ea

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

graphite-app · 2024-09-25T22:22:15Z

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

vercel · 2024-09-25T22:22:16Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
thirdweb-www	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Sep 26, 2024 8:47pm

3 Skipped Deployments

Name	Status	Updated (UTC)
docs-v2	⬜️ Skipped (Inspect)	Sep 26, 2024 8:47pm
thirdweb_playground	⬜️ Skipped (Inspect)	Sep 26, 2024 8:47pm
wallet-ui	⬜️ Skipped (Inspect)	Sep 26, 2024 8:47pm

MananTank · 2024-09-25T22:22:31Z

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @MananTank and the rest of your teammates on Graphite

codecov · 2024-09-25T22:23:36Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.66%. Comparing base (09b1c28) to head (88db5ea).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #4807   +/-   ##
=======================================
  Coverage   47.66%   47.66%           
=======================================
  Files        1051     1051           
  Lines       56714    56714           
  Branches     3892     3892           
=======================================
  Hits        27032    27032           
  Misses      28995    28995           
  Partials      687      687

Flag	Coverage Δ		*Carryforward flag
legacy_packages	`65.68% <ø> (ø)`		Carriedforward from 09b1c28
packages	`43.38% <ø> (ø)`

*This pull request uses carry forward flags. Click here to find out more.

github-actions · 2024-09-25T22:25:33Z

size-limit report 📦

Path	Size	Loading time (3g)	Running time (snapdragon)	Total time
thirdweb (esm)	41.93 KB (0%)	839 ms (0%)	406 ms (+30.02% 🔺)	1.3 s
thirdweb (cjs)	101.55 KB (0%)	2.1 s (0%)	809 ms (+23.02% 🔺)	2.9 s
thirdweb (minimal + tree-shaking)	4.82 KB (0%)	97 ms (0%)	70 ms (+90.56% 🔺)	166 ms
thirdweb/chains (tree-shaking)	498 B (0%)	10 ms (0%)	42 ms (+600% 🔺)	52 ms
thirdweb/react (minimal + tree-shaking)	16.78 KB (0%)	336 ms (0%)	150 ms (+63.11% 🔺)	485 ms

apps/dashboard/src/app/account/settings/AccountSettingsPage.tsx

graphite-app · 2024-09-26T20:42:19Z

Merge activity

Sep 26, 4:42 PM EDT: MananTank added this pull request to the Graphite merge queue.
Sep 26, 4:48 PM EDT: MananTank merged this pull request with the Graphite merge queue.

## Problem solved Short description of the bug fixed or feature added  --- ## PR-Codex overview This PR focuses on enhancing the account and team settings pages by adding image upload functionality for accounts and teams, updating component imports, and improving layout responsiveness. ### Detailed summary - Added `updateAccountImage` method to `AccountSettingsPage` and `AccountSettingsPageUI`. - Introduced `updateTeamImage` method in `TeamGeneralSettingsPage` and `TeamGeneralSettingsPageUI`. - Changed layout from `min-h-full` to `min-h-screen`. - Updated import statements to reflect new component names. - Implemented async image upload functionality with IPFS integration. - Added error handling for image update methods. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

vercel bot temporarily deployed to Preview – thirdweb_playground September 25, 2024 22:22 Inactive

vercel bot temporarily deployed to Preview – wallet-ui September 25, 2024 22:22 Inactive

vercel bot temporarily deployed to Preview – docs-v2 September 25, 2024 22:22 Inactive

github-actions bot added the Dashboard Involves changes to the Dashboard. label Sep 25, 2024

MananTank marked this pull request as ready for review September 25, 2024 22:22

MananTank requested review from jnsdls and joaquim-verges as code owners September 25, 2024 22:22

MananTank mentioned this pull request Sep 25, 2024

Add Img component with skeleton + fallback support #4791

Merged

MananTank mentioned this pull request Sep 25, 2024

Replace Avatar placeholders with Avatar components in teams and account layout #4803

Merged

vercel bot deployed to Preview – thirdweb-www September 25, 2024 22:31 View deployment

jnsdls requested changes Sep 26, 2024

View reviewed changes

apps/dashboard/src/app/account/settings/AccountSettingsPage.tsx Show resolved Hide resolved

MananTank requested a review from jnsdls September 26, 2024 07:56

jnsdls approved these changes Sep 26, 2024

View reviewed changes

apps/dashboard/src/app/account/settings/AccountSettingsPage.tsx Show resolved Hide resolved

MananTank force-pushed the 09-25-replace_avatar_placeholders_with_avatar_components_in_teams_and_account_layout branch from 2ca6b52 to 0ada3e8 Compare September 26, 2024 20:02

MananTank force-pushed the 09-26-add_upload_to_ipfs_on_teams_account_avatar_form_fields branch from 373e11c to eff10b6 Compare September 26, 2024 20:02

vercel bot temporarily deployed to Preview – docs-v2 September 26, 2024 20:02 Inactive

vercel bot temporarily deployed to Preview – thirdweb_playground September 26, 2024 20:02 Inactive

vercel bot temporarily deployed to Preview – wallet-ui September 26, 2024 20:02 Inactive

vercel bot deployed to Preview – thirdweb-www September 26, 2024 20:14 View deployment

MananTank force-pushed the 09-25-replace_avatar_placeholders_with_avatar_components_in_teams_and_account_layout branch from 0ada3e8 to 09b1c28 Compare September 26, 2024 20:43

MananTank force-pushed the 09-26-add_upload_to_ipfs_on_teams_account_avatar_form_fields branch from eff10b6 to 88db5ea Compare September 26, 2024 20:44

vercel bot temporarily deployed to Preview – docs-v2 September 26, 2024 20:44 Inactive

vercel bot temporarily deployed to Preview – wallet-ui September 26, 2024 20:44 Inactive

vercel bot temporarily deployed to Preview – thirdweb_playground September 26, 2024 20:44 Inactive

Base automatically changed from 09-25-replace_avatar_placeholders_with_avatar_components_in_teams_and_account_layout to main September 26, 2024 20:46

vercel bot deployed to Preview – thirdweb-www September 26, 2024 20:47 View deployment

graphite-app bot merged commit 88db5ea into main Sep 26, 2024

graphite-app bot deleted the 09-26-add_upload_to_ipfs_on_teams_account_avatar_form_fields branch September 26, 2024 20:48

vercel bot temporarily deployed to Production – wallet-ui September 26, 2024 20:48 Inactive

vercel bot temporarily deployed to Production – docs-v2 September 26, 2024 20:48 Inactive

vercel bot temporarily deployed to Production – thirdweb_playground September 26, 2024 20:48 Inactive

vercel bot deployed to Production – thirdweb-www September 26, 2024 21:05 View deployment

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add upload to IPFS on teams & account avatar form fields #4807

Add upload to IPFS on teams & account avatar form fields #4807

Uh oh!

MananTank commented Sep 25, 2024 •

edited by pr-codex bot

Loading

Uh oh!

changeset-bot bot commented Sep 25, 2024 •

edited

Loading

Uh oh!

graphite-app bot commented Sep 25, 2024

Uh oh!

vercel bot commented Sep 25, 2024 •

edited

Loading

Uh oh!

MananTank commented Sep 25, 2024 •

edited

Loading

Uh oh!

codecov bot commented Sep 25, 2024 •

edited

Loading

Uh oh!

github-actions bot commented Sep 25, 2024 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

graphite-app bot commented Sep 26, 2024 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Add upload to IPFS on teams & account avatar form fields #4807

Add upload to IPFS on teams & account avatar form fields #4807

Uh oh!

Conversation

MananTank commented Sep 25, 2024 • edited by pr-codex bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Problem solved

PR-Codex overview

Detailed summary

Uh oh!

changeset-bot bot commented Sep 25, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

graphite-app bot commented Sep 25, 2024

Your org has enabled the Graphite merge queue for merging into main

Uh oh!

vercel bot commented Sep 25, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MananTank commented Sep 25, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Sep 25, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions bot commented Sep 25, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

size-limit report 📦

Uh oh!

Uh oh!

Uh oh!

graphite-app bot commented Sep 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

MananTank commented Sep 25, 2024 •

edited by pr-codex bot

Loading

changeset-bot bot commented Sep 25, 2024 •

edited

Loading

vercel bot commented Sep 25, 2024 •

edited

Loading

MananTank commented Sep 25, 2024 •

edited

Loading

codecov bot commented Sep 25, 2024 •

edited

Loading

github-actions bot commented Sep 25, 2024 •

edited

Loading

graphite-app bot commented Sep 26, 2024 •

edited

Loading